Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abap environment update addon product #4774

Merged
merged 44 commits into from
Feb 20, 2024

Conversation

ranliii
Copy link
Contributor

@ranliii ranliii commented Jan 15, 2024

Changes

  • Tests
  • Documentation

@ranliii ranliii requested review from a team as code owners January 15, 2024 10:50
vars/abapEnvironmentPipelineStageIntegrationTests.groovy Outdated Show resolved Hide resolved
vars/abapEnvironmentPipelineStageIntegrationTests.groovy Outdated Show resolved Hide resolved
vars/abapEnvironmentPipelineStageIntegrationTests.groovy Outdated Show resolved Hide resolved
vars/abapEnvironmentPipelineStageIntegrationTests.groovy Outdated Show resolved Hide resolved
vars/abapEnvironmentPipelineStageIntegrationTests.groovy Outdated Show resolved Hide resolved
vars/abapEnvironmentPipelineStageIntegrationTests.groovy Outdated Show resolved Hide resolved
.DS_Store Outdated Show resolved Hide resolved
@tiloKo tiloKo added the ABAP label Jan 26, 2024
cmd/abapLandscapePortalUpdateAddOnProduct.go Outdated Show resolved Hide resolved
cmd/abapLandscapePortalUpdateAddOnProduct.go Outdated Show resolved Hide resolved
cmd/abapLandscapePortalUpdateAddOnProduct.go Outdated Show resolved Hide resolved
cmd/abapLandscapePortalUpdateAddOnProduct.go Outdated Show resolved Hide resolved
cmd/abapLandscapePortalUpdateAddOnProduct.go Outdated Show resolved Hide resolved
cmd/abapLandscapePortalUpdateAddOnProduct.go Outdated Show resolved Hide resolved
cmd/abapLandscapePortalUpdateAddOnProduct.go Show resolved Hide resolved
cmd/abapLandscapePortalUpdateAddOnProduct.go Outdated Show resolved Hide resolved
cmd/abapLandscapePortalUpdateAddOnProduct.go Show resolved Hide resolved
@ranliii ranliii requested review from inf2381 and a team as code owners February 12, 2024 15:21
@ranliii ranliii removed request for a team and inf2381 February 12, 2024 15:22
Copy link
Member

@tiloKo tiloKo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tiloKo
Copy link
Member

tiloKo commented Feb 20, 2024

/it

Copy link

sonarcloud bot commented Feb 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ranliii ranliii enabled auto-merge (squash) February 20, 2024 18:23
@tiloKo
Copy link
Member

tiloKo commented Feb 20, 2024

/it

@ranliii ranliii merged commit f123411 into master Feb 20, 2024
13 of 14 checks passed
@ranliii ranliii deleted the abap-environment-update-addon-product branch February 20, 2024 18:39
@ranliii ranliii restored the abap-environment-update-addon-product branch February 26, 2024 15:33
maxatsap pushed a commit to maxatsap/jenkins-library that referenced this pull request Jul 23, 2024
* new Piper step abapEnvironmentUpdateAddOnProduct

* modified entity json format and some minor function changes

* modified groovy file for pipelineStageIntTests and addonDescriptor to be mandatory in yaml file

* sync with fork branch ranliii/abap-environment-update-addon-product

* added generated file

* fail the step as long as addon update not successful and unit tests

* added docu for the new step

* tried to fix groovy unit test

* tried to fix groovy unit test 2

* for test

* fixed error

* fixed error 2

* tried to fix groovy unit test error

* added groovy unit test for new Piper step

* tried to fix groovy unit test error

* tried to fix groovy unit test error 2

* changes after first review

* remove .DS_Store

* for test

* revert test relevant changes

* try to fix groovy test error

* try to fix groovy error

* 3rd try to fix groovy test error

* rewrite the failed groovy test

* small changes and try with timeout as well as poll interval

* changes for test

* revert test-related changes

* try to fix errors

* Revert "Merge branch 'master' into abap-environment-update-addon-product"

This reverts commit 1ee0bcd, reversing
changes made to 3c4a99d.

* try to fix error

* try to fix error 2

* try to fix error 3

* align go.mod with master branch

* revert go.mod to commit 3c4a99d

* for test

* revert test changes

* new unit test

* Revert "Revert "Merge branch 'master' into abap-environment-update-addon-product""

This reverts commit 363c038.

* go generate after merging master

---------

Co-authored-by: Jk1484 <[email protected]>
Co-authored-by: Ran Li <[email protected]>
Co-authored-by: tiloKo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants